Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding Export Captures button #168

Merged
merged 3 commits into from
Nov 28, 2021
Merged

feat: adding Export Captures button #168

merged 3 commits into from
Nov 28, 2021

Conversation

tranquanghuy0801
Copy link
Member

@tranquanghuy0801 tranquanghuy0801 commented Sep 30, 2021 •
edited
Loading

Resolves #52

@tranquanghuy0801
Copy link
Member Author

Screenshot 2021-09-30 at 22 27 29

@nmcharlton
Copy link
Collaborator

This is looking great 👍

@tranquanghuy0801 tranquanghuy0801 marked this pull request as ready for review October 27, 2021 12:22
@nmcharlton nmcharlton removed the request for review from luacmartins October 30, 2021 08:09
nmcharlton
nmcharlton requested changes Oct 31, 2021
View reviewed changes
src/components/ExportCapture.js Outdated Show resolved Hide resolved
src/components/ExportCapture.js Outdated Show resolved Hide resolved
src/components/ExportCapture.js Outdated Show resolved Hide resolved
src/components/ExportCapture.js Outdated Show resolved Hide resolved
src/components/ExportCapture.js Outdated Show resolved Hide resolved
src/components/ExportCapture.js Outdated Show resolved Hide resolved
src/components/ExportCapture.js Outdated Show resolved Hide resolved
src/components/ExportCapture.js Outdated Show resolved Hide resolved
src/components/ExportCapture.js Outdated Show resolved Hide resolved
@tranquanghuy0801
Copy link
Member Author

@nmcharlton
Sorry for the delay on doing this. I was busy on other tasks at work.
For this issue, I have made some changes:

  • Remove all conditions for other columns in function processDownloadData() except for the id and planterID as they are applied <LinkToWebMap> in formatCell
  • Added a linear progress feedback at the end of Export Captures form when you click Download. I just put here for start, I think you might want to change this. You can ask the Design team for this feature and I will update then.
  • Fixed the issue of only getting the data at 2nd download time.

@nmcharlton
Copy link
Collaborator

nmcharlton commented Nov 24, 2021 •
edited
Loading

Well done, this is a lot better!
I think the progress bar in the dialog works well.

One more suggestion: Disable the buttons in the dialog while downloading is in progress and close the dialog when downloading is complete.

nmcharlton
nmcharlton requested changes Nov 24, 2021
View reviewed changes
src/context/CapturesContext.js Outdated Show resolved Hide resolved
src/context/CapturesContext.js Show resolved Hide resolved
@tranquanghuy0801 tranquanghuy0801 changed the title Adding Export Captures button feat: adding Export Captures button Nov 25, 2021
@tranquanghuy0801 tranquanghuy0801 requested a review from a team as a code owner November 25, 2021 04:47
nmcharlton
nmcharlton approved these changes Nov 28, 2021
View reviewed changes
Copy link
Collaborator

@nmcharlton nmcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @tranquanghuy0801, thank you!

@nmcharlton nmcharlton merged commit f59a11c into Greenstand:master Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmcharlton nmcharlton nmcharlton approved these changes

@gwynndp gwynndp Awaiting requested review from gwynndp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export Captures as csv
2 participants
@tranquanghuy0801 @nmcharlton